Add wrapt as explicit dependency to observability packages#212
Open
juliomenendez wants to merge 1 commit intomainfrom
Open
Add wrapt as explicit dependency to observability packages#212juliomenendez wants to merge 1 commit intomainfrom
juliomenendez wants to merge 1 commit intomainfrom
Conversation
observability-core and observability-extensions-langchain both directly import wrapt (ObjectProxy and wrap_function_wrapper respectively) but never declared it as a dependency. Users installing observability-core without an extension package that pulls in opentelemetry-instrumentation would hit "No module named 'wrapt'" at SDK init time. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures wrapt is declared as an explicit dependency for the observability packages that import it, preventing standalone installs from failing with No module named 'wrapt'.
Changes:
- Add
wrapttomicrosoft-agents-a365-observability-coreruntime dependencies. - Add
wrapttomicrosoft-agents-a365-observability-extensions-langchainruntime dependencies. - Add a centralized minimum version constraint for
wrapt(>= 1.14) in the workspaceconstraint-dependencies.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Adds wrapt >= 1.14 to centralized constraint-dependencies used by uv. |
| libraries/microsoft-agents-a365-observability-extensions-langchain/pyproject.toml | Declares wrapt as a direct dependency for the LangChain extension package. |
| libraries/microsoft-agents-a365-observability-core/pyproject.toml | Declares wrapt as a direct dependency for the core observability package. |
nikhilNava
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No module named 'wrapt'when initializing the A365 observability SDKobservability-coreimportswrapt.ObjectProxyandobservability-extensions-langchainimportswrapt.wrap_function_wrapper, but neither declaredwraptas a dependencywraptonly arrived transitively viaopentelemetry-instrumentation, whichobservability-coredoesn't depend on — so standalone installs of the core package would failwraptas explicit dependency to both packages and addedwrapt >= 1.14to root constraint-dependenciesTest plan
uv lock && uv sync --locked --all-extras --devsucceedsuv run --frozen ruff check .passeswraptconfirmed as direct dependency in lockfile for both packages🤖 Generated with Claude Code